Ability to set a different configuration file per role. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added role as parameter of start method, it will try to check if there was an specific config set for the given role using the convention #{role_name}_config otherwise will check the default :sidekiq_config.
it brings the capability to have different roles processing a separated set of queues from the config. i use this so i can isolate heavier queues such exports on their own infrastructure.
| @@ -276,4 +277,10 @@ namespace :sidekiq do | |||
| properties.fetch(:run_as) || # global property across multiple capistrano gems | |||
| role.user | |||
| end | |||
|
|
|||
| def sidekiq_config(role) | |||
| sidekiq_roles = Array.wrap(fetch(:sidekiq_roles)) || [] | |||
There was a problem hiding this comment.
.wrap is rails specific API, won't be working for non Rails App.
On top of that, || [] is redundant.
Array(fetch(:sidekiq_roles)) would be enough.
|
@lustercr , this is broken with monit enabled. You can test it out as such; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added role as a parameter of the start method, it will try to check if there was a specific config set for the given role using the convention
#{role_name}_configotherwise will check the default:sidekiq_config.it brings the capability to have different roles processing a separated set of queues from the config. i use this so I can isolate heavier queues such exports on their own infrastructure.
I hope this makes sense to be in the core.