Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support role specific configuration values #158

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kpheasey
Copy link

Add support role specific configuration values for the following options:

  • :sidekiq_env
  • :sidekiq_log
  • :sidekiq_require
  • :sidekiq_tag
  • :sidekiq_queue
  • :sidekiq_config
  • :sidekiq_concurrency
  • :sidekiq_option_per_process
  • :sidekiq_options

Kevin Pheasey added 2 commits July 13, 2016 14:27
…ekiq_log, :sidekiq_require, :sidekiq_tag, :sidekiq_queue, :sidekiq_config, :sidekiq_concurrency, :sidekiq_option_per_process, : and sidekiq_options variables.
@kpheasey
Copy link
Author

@seuros Just wanted to add that this is a more complete solution for role specific configuration as compared to the following pending pull requests. Additionally, It uses the [role]_[option] naming scheme that is already being implemented with :sidekiq_processes

silentshade added a commit to silentshade/capistrano-sidekiq that referenced this pull request Mar 23, 2017
Add support role specific configuration values seuros#158
@joelmats
Copy link

joelmats commented May 7, 2017

+1 When will this be merged?

@AlexanderFisenko
Copy link

Same question

@lustercr
Copy link

hi @seuros, is there an alternative way to support this in the current version, I been using a fork from @kpheasey for over a year and things worked fine, however, I'm now upgrading to latest Capistrano and I'm facing the issue you fixed here #160.

if you think this is a feature that will contribute to the project, I'm more than glad to help reforking and applying @kpheasey changes to latests version.

in my case I use different configs not only for a different number of process per machine size, but i distribute the queues to different machines, critical and fast processing queues go to one machine role and the non-critical or heavy process such export go to a different set of machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants