Trying to fixe a performance issue related to resource copying

serenity-bdd · Dec 25, 2015 · 7e41d67 · 7e41d67
1 parent 0061513
commit 7e41d67
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/serenity-core/src/main/java/net/thucydides/core/reports/html/HtmlResourceCopier.java b/serenity-core/src/main/java/net/thucydides/core/reports/html/HtmlResourceCopier.java
@@ -17,7 +17,7 @@ public class HtmlResourceCopier {
 
     private String resourceDirectory;
 
-    private static final Object htmlReportResources = new Object();
+//    private static final Object htmlReportResources = new Object();
 
     public HtmlResourceCopier(final String resourceDirectory) {
         super();
@@ -35,19 +35,17 @@ public void to(final File targetDirectory) throws IOException {
             return;
         }
 
-        synchronized (htmlReportResources) {
-            recordResourceMarkerIn(targetDirectory);
-            Pattern resourcePattern = allFilesInDirectory(resourceDirectory);
-            FileResources fileResource = FileResources.from(resourceDirectory);
+        recordResourceMarkerIn(targetDirectory);
+        Pattern resourcePattern = allFilesInDirectory(resourceDirectory);
+        FileResources fileResource = FileResources.from(resourceDirectory);
 
-            Collection<String> reportResources = ResourceList.forResources(resourcePattern).list();
+        Collection<String> reportResources = ResourceList.forResources(resourcePattern).list();
 
-            for (String resourcePath : reportResources) {
-                if (fileResourceFromAJar(resourcePath)) {
-                    fileResource.copyResourceTo(resourcePath, targetDirectory);
-                } else if (fileResourceFromPath(resourcePath)) {
-                    fileResource.copyResourceTo(resourcePath, targetDirectory);
-                }
+        for (String resourcePath : reportResources) {
+            if (fileResourceFromAJar(resourcePath)) {
+                fileResource.copyResourceTo(resourcePath, targetDirectory);
+            } else if (fileResourceFromPath(resourcePath)) {
+                fileResource.copyResourceTo(resourcePath, targetDirectory);
             }
         }
     }