Merge pull request #82 from eskape/master

Fix for setting up the remote webdriver capability: webdriver.remote.browser.version
serenity-bdd · Jun 24, 2015 · 6086f27 · 6086f27
2 parents b06c399 + 395a9a6
commit 6086f27
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/serenity-core/src/main/java/net/thucydides/core/webdriver/WebDriverFactory.java b/serenity-core/src/main/java/net/thucydides/core/webdriver/WebDriverFactory.java
@@ -359,7 +359,7 @@ private DesiredCapabilities capabilitiesForDriver(String driver) {
 
         Preconditions.checkNotNull(driverType, "Unsupported remote driver type: ");
 
-        if (driverType == SupportedWebDriver.REMOTE) {
+        if (shouldUseARemoteDriver()) {
             return (DesiredCapabilities) enhancedCapabilities(remoteCapabilities());
         } else {
             return (DesiredCapabilities) enhancedCapabilities(realBrowserCapabilities(driverType));
@@ -418,7 +418,11 @@ private DesiredCapabilities realBrowserCapabilities(SupportedWebDriver driverTyp
     }
 
     private DesiredCapabilities remoteCapabilities() {
-        String remoteBrowser = ThucydidesSystemProperty.WEBDRIVER_REMOTE_DRIVER.from(environmentVariables, "firefox");
+        String remoteBrowser = ThucydidesSystemProperty.WEBDRIVER_REMOTE_DRIVER.from(environmentVariables, getDriverFrom(environmentVariables));
+        if (remoteBrowser == null) {
+            remoteBrowser = "firefox";
+        }
+
         DesiredCapabilities capabilities = realBrowserCapabilities(driverTypeFor(remoteBrowser));
         capabilities.setCapability("idle-timeout",EXTRA_TIME_TO_TAKE_SCREENSHOTS);
 
@@ -431,9 +435,10 @@ private DesiredCapabilities remoteCapabilities() {
         }
 
         if (environmentVariables.getProperty(ThucydidesSystemProperty.WEBDRIVER_REMOTE_BROWSER_VERSION) != null) {
-            capabilities.setCapability("version", Platform.valueOf(environmentVariables.getProperty(ThucydidesSystemProperty.WEBDRIVER_REMOTE_BROWSER_VERSION)));
+            capabilities.setCapability("version", environmentVariables.getProperty(ThucydidesSystemProperty.WEBDRIVER_REMOTE_BROWSER_VERSION));
         }
 
+
         return capabilities;
     }