From 573bf3cb755e629ad3867dc8fc3d871e9d372c73 Mon Sep 17 00:00:00 2001
From: Oleg Ridchenko <73664101+oleg-rd@users.noreply.github.com>
Date: Mon, 5 Feb 2024 18:46:06 +0200
Subject: [PATCH] getChildResults(): reduce the amount of invocation of
 getResult() method (#3396)

---
 .../main/java/net/thucydides/model/domain/TestStep.java   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java b/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java
index 215f309cd..a8d78e305 100644
--- a/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java
+++ b/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java
@@ -491,12 +491,14 @@ private TestResult getResultFromChildren() {
         return TestResultList.overallResultFrom(getChildResults());
     }
 
-
     private List<TestResult> getChildResults() {
         List<TestResult> childResults = new ArrayList<>();
         for (TestStep step : getChildren()) {
-            if (step != null && step.getResult() != null) {
-                childResults.add(step.getResult());
+            if (step != null) {
+                TestResult stepResult = step.getResult();
+                if (stepResult != null) {
+                    childResults.add(stepResult);
+                }
             }
         }
         return childResults;