warning: useless conversion to the same type: `alloc::string::String` --> src/models/transactions/signer_list_set.rs:136:28 | 136 | found: account.into(), | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `models::exceptions::XRPLModelException` --> src/models/transactions/nftoken_mint.rs:155:21 | 155 | Err(XRPLModelException::ValueTooLong { | _____________________^ 156 | | field: "uri".into(), 157 | | max: MAX_URI_LENGTH, 158 | | found: uri.len(), 159 | | } 160 | | .into()) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 155 ~ Err(XRPLModelException::ValueTooLong { 156 + field: "uri".into(), 157 + max: MAX_URI_LENGTH, 158 + found: uri.len(), 159 ~ }) |

warning: useless conversion to the same type: `models::exceptions::XRPLModelException` --> src/models/transactions/nftoken_mint.rs:138:21 | 138 | Err(XRPLModelException::ValueTooHigh { | _____________________^ 139 | | field: "transfer_fee".into(), 140 | | max: MAX_TRANSFER_FEE, 141 | | found: transfer_fee, 142 | | } 143 | | .into()) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 138 ~ Err(XRPLModelException::ValueTooHigh { 139 + field: "transfer_fee".into(), 140 + max: MAX_TRANSFER_FEE, 141 + found: transfer_fee, 142 ~ }) |

warning: useless conversion to the same type: `models::exceptions::XRPLModelException` --> src/models/transactions/nftoken_mint.rs:122:21 | 122 | Err(XRPLModelException::ValueEqualsValue { | _____________________^ 123 | | field1: "issuer".into(), 124 | | field2: "account".into(), 125 | | } 126 | | .into()) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 122 ~ Err(XRPLModelException::ValueEqualsValue { 123 + field1: "issuer".into(), 124 + field2: "account".into(), 125 ~ }) |

warning: question mark operator is useless here --> src/models/requests/ledger_entry.rs:99:9 | 99 | Ok(self._get_field_error()?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self._get_field_error()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

warning: question mark operator is useless here --> src/core/binarycodec/types/paths.rs:370:9 | 370 | Ok(Path::new(Some(&buffer))?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Path::new(Some(&buffer))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

warning: question mark operator is useless here --> src/core/binarycodec/types/paths.rs:354:9 | 354 | Ok(Self::new(Some(&buffer))?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Self::new(Some(&buffer))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

warning: question mark operator is useless here --> src/core/binarycodec/types/hash.rs:179:9 | 179 | Ok(parser.read(read_length)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `parser.read(read_length)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default

warning: useless conversion to the same type: `core::exceptions::XRPLCoreException` --> src/core/binarycodec/types/amount.rs:348:17 | 348 | / XRPLCoreException::SerdeJsonError(XRPLSerdeJsonError::UnexpectedValueType { 349 | | expected: "String/Object".into(), 350 | | found: value, 351 | | }) 352 | | .into(), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 348 ~ XRPLCoreException::SerdeJsonError(XRPLSerdeJsonError::UnexpectedValueType { 349 + expected: "String/Object".into(), 350 + found: value, 351 ~ }), |

warning: redundant closure --> src/core/addresscodec/mod.rs:152:26 | 152 | .map_err(|err| XRPLAddressCodecException::VecResizeError(err))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `XRPLAddressCodecException::VecResizeError` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: this lifetime isn't used in the function definition --> src/asynch/transaction/mod.rs:279:33 | 279 | fn is_not_later_rippled_version<'a>(source: String, target: String) -> XRPLHelperResult<bool> { | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

warning: useless conversion to the same type: `asynch::exceptions::XRPLHelperException` --> src/asynch/transaction/mod.rs:272:27 | 272 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `alloc::string::String` --> src/asynch/transaction/submit_and_wait.rs:98:25 | 98 | / format!("{}: {}", error, response.error_message.unwrap_or("".into())) 99 | | .into(), | |___________________________________^ help: consider removing `.into()`: `format!("{}: {}", error, response.error_message.unwrap_or("".into()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: redundant closure --> src/asynch/clients/websocket/websocket_base.rs:82:26 | 82 | .map_err(|e| XRPLWebSocketException::MessageChannelError(e))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `XRPLWebSocketException::MessageChannelError` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: unreachable statement --> src/asynch/mod.rs:25:5 | 22 | return; | ------ any code following this expression is unreachable ... 25 | / { 26 | | embassy_time::Timer::after_secs(1).await; 27 | | return; 28 | | } | |_____^ unreachable statement | = note: `#[warn(unreachable_code)]` on by default

warning: unneeded sub `cfg` when there is only one condition --> src/lib.rs:56:7 | 56 | #[cfg(any(feature = "models"))] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "models"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

warning: unneeded sub `cfg` when there is only one condition --> src/lib.rs:45:7 | 45 | #[cfg(any(feature = "models"))] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "models"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg = note: `#[warn(clippy::non_minimal_cfg)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/