Skip to content

Refactoring

Refactoring #201

Triggered via pull request September 8, 2024 11:53
Status Success
Total duration 4m 10s
Artifacts

unit_test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
this `else { if .. }` block can be collapsed: src/models/results/mod.rs#L333
warning: this `else { if .. }` block can be collapsed --> src/models/results/mod.rs:333:16 | 333 | } else { | ________________^ 334 | | if let Some(result) = &self.result { 335 | | match serde_json::to_value(result) { 336 | | Ok(value) => match value.get("status") { ... | 344 | | } 345 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 333 ~ } else if let Some(result) = &self.result { 334 + match serde_json::to_value(result) { 335 + Ok(value) => match value.get("status") { 336 + Some(Value::String(status)) => status == "success", 337 + _ => false, 338 + }, 339 + _ => false, 340 + } 341 + } else { 342 + false 343 + } |
constants have by default a `'static` lifetime: src/asynch/wallet/mod.rs#L21
warning: constants have by default a `'static` lifetime --> src/asynch/wallet/mod.rs:21:24 | 21 | const DEV_FAUCET_URL: &'static str = "https://faucet.devnet.rippletest.net/accounts"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
constants have by default a `'static` lifetime: src/asynch/wallet/mod.rs#L20
warning: constants have by default a `'static` lifetime --> src/asynch/wallet/mod.rs:20:25 | 20 | const TEST_FAUCET_URL: &'static str = "https://faucet.altnet.rippletest.net/accounts"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
unneeded unit return type: src/asynch/clients/client.rs#L25
warning: unneeded unit return type --> src/asynch/clients/client.rs:25:60 | 25 | fn set_request_id(&self, request: &mut XRPLRequest<'_>) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
xrpl-rust
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
xrpl-rust
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
xrpl-rust: src/asynch/clients/mod.rs#L9
unused import: `anyhow::Result`
xrpl-rust: src/asynch/clients/mod.rs#L12
unused import: `url::Url`
xrpl-rust
`xrpl-rust` (lib) generated 2 warnings (run `cargo fix --lib -p xrpl-rust` to apply 2 suggestions)
xrpl-rust
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
xrpl-rust
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
xrpl-rust
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
xrpl-rust
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/