Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter is unreliable? #10

Open
W-Jie opened this issue Jun 8, 2017 · 2 comments
Open

Filter is unreliable? #10

W-Jie opened this issue Jun 8, 2017 · 2 comments

Comments

@W-Jie
Copy link

W-Jie commented Jun 8, 2017

I imported this package in the project, thank you!
But I found the filter unreliable. When I load about 500,000 data from the database and use the method InsertUnique to filter, I found that about 4000 data returned true.It means that the data is already repeated?
But,the database table has already made a unique primary key.And I confirm that the data is not duplicated in the database.

@seiflotfy
Copy link
Owner

seiflotfy commented Jun 8, 2017 via email

@seiflotfy
Copy link
Owner

2 Questions

  1. how big is your filter
  2. generally 4k out of 500k means that less than 0.8% false positive rate. Might be expected with 1 byte fingerprints, I am adding a compact 12bit fingerprint version that should reduce the false positive rate. But it depends on the size of the cuckoo filter (So back to question 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants