Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DP-2568] - topiccctl keystore bug fix for docker-compose-auth #210

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ssingudasu
Copy link
Contributor

@ssingudasu ssingudasu commented Dec 6, 2024

Description

docker-compose-auth KAFKA_CFG_SSL_KEYSTORE_LOCATION has been configured incorrectly causing tls connections to fail(9093, 9095 ports)

This PR is a bug fix to change KAFKA_CFG_SSL_KEYSTORE_LOCATION to correct value kafka.keystore.jks

Testing:

Before fix:

STEP-1: Spin up docker-compose
$ docker-compose -f ./docker-compose-auth.yml up -d

STEP-2: Build topicctl
$ go build -o ./build/topicctl -a ./cmd/topicctl

STEP-3: Connect to cluster via auth (brokerAddr: localhost:9095)
$ ./build/topicctl get topics --cluster-config examples/auth/cluster.yaml
[2024-12-06 12:21:37] ERROR tls: first record does not look like a TLS handshake

After fix:

STEP-1: Spin up docker-compose
$ docker-compose -f ./docker-compose-auth.yml up -d

STEP-2: Build topicctl
$ go build -o ./build/topicctl -a ./cmd/topicctl

STEP-3: Connect to cluster via auth (brokerAddr: localhost:9095)
$ ./build/topicctl get topics --cluster-config examples/auth/cluster.yaml
[2024-12-06 12:25:47]  INFO Topics:
-------+------------+-------------+-----------+------------
  NAME | PARTITIONS | REPLICATION | RETENTION |   RACKS
       |            |             |   MINS    | (MIN,MAX)
-------+------------+-------------+-----------+------------
-------+------------+-------------+-----------+------------

@ssingudasu ssingudasu requested a review from a team as a code owner December 6, 2024 20:21
@ssingudasu ssingudasu merged commit b18d4f6 into master Dec 6, 2024
8 checks passed
@ssingudasu ssingudasu deleted the ssingudasu/dp-2568-keystore-docker-bug-fix branch December 6, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants