-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: for Unable to configure Custom Domain for React-Native #1043
Conversation
- updated test cases in fetchSettings.test.ts and SegmentDestination.test.ts - added new test cases in util.test.ts
unblock e2e teststhe following should unblock the e2e the tests:
NOTE that you need provide the write key to the endpoints best practicehowever, your changes hardcoded the path/endpoints to every domain, which disables the user to fully customize the url to their own endpoints and this is a breaking change. the suggested fix would be:
|
update business logic to configure custom proxy, updated test cases and tested e2e test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just address the only comment and update README and it's ready to go
fix: for Unable to configure Custom Domain for React-Native