docs: 📝 add sections on making or dealing with stacked PRs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
requested changes
Mar 11, 2025
Comment on lines
+71
to
+72
| - After each stacked PR has been approved, rebase all of them onto the | ||
| base PR. |
There was a problem hiding this comment.
Do we have to wait until all stacked PRs have been approved or can we rebase each as soon as they’ve been approved?
Comment on lines
+43
to
+46
| - As each stacked pull request is ready for review, team members will | ||
| review and make suggestions as needed. As the author, you'll need to | ||
| make sure all suggestions are merged downstream to the later pull | ||
| requests by rebasing. |
There was a problem hiding this comment.
So, authors of stacked PRs are responsible for rebasing each stacked PR to the base PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've moved our retrospective discussions and agreements into the team doc.
This PR needs a quick review.
Checklist
just run-all