docs: 📝 add collaboration design principles #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
requested changes
Feb 10, 2025
organisation/collaboration.qmd
Outdated
Comment on lines
34
to
36
| read what we write. We also recognize that some things are private and | ||
| should be kept private, and we aim to be clear about what those things | ||
| are. |
There was a problem hiding this comment.
Should we be clear on what those things are explicitly here, maybe?
There was a problem hiding this comment.
I considered that, but I think this doc should contain more of the general principles and the guidebook or teams repo would contain the detailed, descriptive stuff. It could go under design patterns though 🤔
There was a problem hiding this comment.
It could be nice to include an example here, maybe? :)
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
signekb
previously approved these changes
Feb 12, 2025
organisation/collaboration.qmd
Outdated
Comment on lines
34
to
36
| read what we write. We also recognize that some things are private and | ||
| should be kept private, and we aim to be clear about what those things | ||
| are. |
There was a problem hiding this comment.
It could be nice to include an example here, maybe? :)
lwjohnst86
commented
Feb 12, 2025
martonvago
requested changes
Feb 13, 2025
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm adding some principles on collaborating, which has so far been mostly in my head or verbally talked about.
This PR needs an in-depth review.
Checklist
just run-all