Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: large update why quarto #48

Merged
merged 8 commits into from
May 15, 2024
Merged

docs: large update why quarto #48

merged 8 commits into from
May 15, 2024

Conversation

K-Beicher
Copy link
Contributor

Description

Related Issues

Closes This is one of many PRs based on a single issue

Reviewer Focus

This PR requires an in-depth review.

There is a substantial amount of information missing for this document, as it stands it is more like a stump than an actual why document.

Checklist

For general documentation:

  • [x ] Spell-check
    • US
    • UK
  • [ x] Did the page(s) preview correctly on your machine without breaking
  • [ x] New category words (keywords) (if any) added to the code snippet file

@K-Beicher K-Beicher self-assigned this May 10, 2024
@K-Beicher K-Beicher requested a review from a team as a code owner May 10, 2024 09:34
@K-Beicher K-Beicher linked an issue May 10, 2024 that may be closed by this pull request
@K-Beicher K-Beicher changed the title Docs large update why quarto docs: large update why quarto May 10, 2024
signekb
signekb previously approved these changes May 13, 2024
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, since it now fits the template (even though some info is still missing) :)

@lwjohnst86
Copy link
Member

@seedcase-project/developers I've updated this post to include comparisons with other tools.

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 I have added some suggestions and questions

@K-Beicher
Copy link
Contributor Author

@lwjohnst86 If I change the owner of this PR to you, will you be able to merge the changes that Signe has suggested? As far as I can see, they are all comments to the text you added.

lwjohnst86 and others added 2 commits May 15, 2024 13:58
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86
Copy link
Member

@signekb made some changes based on your suggestions 🎉

@lwjohnst86
Copy link
Member

@K-Beicher since I am the owner of the Seedcase Project GitHub repo, I can merge and handle changes just fine ☺️

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🎉 Just one suggestion this time.

Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 disabled auto-merge May 15, 2024 15:00
@lwjohnst86 lwjohnst86 merged commit 49fcd64 into main May 15, 2024
@lwjohnst86 lwjohnst86 deleted the docs-update-why-quarto branch May 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants