Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 synced file(s) with seedcase-project/.github #15

Merged
merged 3 commits into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
justfile
.editorconfig
.gitignore
ruff.toml
63 changes: 63 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
## Description

<!--
This template covers all PRs for Seedcase, please note that if you are
submitting a PR for changes to:
a) General documentation you should delete the sections Testing, Code
Documentation, and the first part of the Author Checklist.
b) Code you should delete the second section of the Author Checklist.
Otherwise, delete any sections that don't apply.
-->

<!-- DO NOT LEAVE THIS SECTION BLANK -->

- This PR {removes/adds/fixes/replaces} the {feature/bug/issue/documentation/tests}.
- These changes are done because of ... {reasons for change/why you're doing it}.

## Related Issues

<!-- List issues the PR closes -->

Closes #...

<!-- Connect this PR to relevant issues, to help the reviewer but also for record-keeping. -->

See also Issues #...

## Testing

- [ ] Yes
- [ ] No, not needed (give a reason below)
- [ ] No, I need help writing them

<!-- Please explain why the tests are not needed for this PR here -->

## Reviewer Focus
<!-- Please delete as appropriate: -->
This PR only needs a quick review.
This PR requires an in-depth review.

<!-- Any particular section the reviewer should focus on, anywhere that would be a good place to start? -->

## Checklist

<!-- This is to help you determine if your work is ready to be reviewed, if an item is not relevant then you can mark it as done (because you have checked and found that it isn't needed) -->

For all PRs that are not general documentation

- [ ] Tests accompany or reflect changes to the code
- [ ] Tests ran and passed locally
- [ ] Ran the linter and formatter
- [ ] Build has passed locally
- [ ] Relevant documentation has been updated

For general documentation:

- [ ] Spell-check
- [ ] US
- [ ] UK
- [ ] Did the page(s) preview correctly on your machine without breaking
- [ ] New category words (keywords) (if any) added to the code snippet file
11 changes: 7 additions & 4 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"files.autoSave": "onFocusChange",
"editor.tabSize": 2,
"editor.wordWrap": "off",
"editor.formatOnSave": false,
"editor.formatOnSave": true,
"git.autofetch": false,
"quarto.visualEditor.markdownWrap": "column",
"quarto.visualEditor.markdownWrapColumn": 72,
Expand All @@ -12,7 +12,7 @@
"editor.tabCompletion": "on",
"editor.snippetSuggestions": "inline",
"conventional-branch.type": [
"build", // Changes that affect the build system or external dependencies
"build", // Changes that affect the build system or external dependencies
"ci", // Changes to our CI configuration files and scripts
"docs", // Documentation only changes
"feat", // A new feature
Expand All @@ -22,5 +22,8 @@
"test", // Adding missing tests or correcting existing tests
"chore", // Misc things, like renaming or deleting files
],
"conventional-branch.format": "{Type}/{Branch}"
}
"conventional-branch.format": "{Type}/{Branch}",
"[python]": {
"editor.defaultFormatter": "charliermarsh.ruff"
}
}