Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📝 Decision post on why to use poetry #14

Merged
merged 3 commits into from
Feb 2, 2024
Merged

docs: 📝 Decision post on why to use poetry #14

merged 3 commits into from
Feb 2, 2024

Conversation

lwjohnst86
Copy link
Member

Closes #4

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner January 29, 2024 11:54
K-Beicher
K-Beicher previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@K-Beicher K-Beicher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. The first one has a bit of a description before the pros and cons, should all of them have a line of what they are, where they are from?

Oh - did you add the new words to the list we are trying to maintain in the code snippets?

signekb
signekb reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have added some suggestions. Like Kris, I think it might be nice with an introductory sentence for each considered option (like Pipenv has)

philter87
philter87 previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@philter87 philter87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting with Hatch and PDM (I did not know about these)

@lwjohnst86 lwjohnst86 dismissed stale reviews from philter87 and K-Beicher via 91b776b February 2, 2024 15:59
lwjohnst86 and others added 2 commits February 2, 2024 16:59
@lwjohnst86 lwjohnst86 merged commit 203192a into main Feb 2, 2024
@lwjohnst86 lwjohnst86 deleted the docs/poetry-decision branch February 2, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signekb signekb signekb left review comments

@philter87 philter87 philter87 left review comments

@K-Beicher K-Beicher K-Beicher left review comments

Assignees

@lwjohnst86 lwjohnst86

Labels
None yet
Projects
No open projects
(Iteration) 2024-01-15: Implement table metadata extract of inputted data in Sprout
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decision post about Poetry
4 participants
@lwjohnst86 @philter87 @signekb @K-Beicher