Skip to content

Commit 91b776b

Browse files
lwjohnst86signekb
andauthored
fix: ✏️ apply suggestions from code review
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
1 parent 361af06 commit 91b776b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

why-poetry.qmd

+6-6
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Managing the packages we depend on (e.g. Django) in Python isn't "simply" instal
1515

1616
The solution to this problem is by using "virtual environments" in Python. These are environments that are separate from the rest of the system and can install any packages without impacting other environments.
1717

18-
The problem is that there multiple ways of creating these virtual environments and managing package dependencies.
18+
There multiple ways of creating these virtual environments and managing package dependencies, and the optional solution depends on the project.
1919

2020
## Decision Drivers
2121

@@ -24,7 +24,7 @@ The problem is that there multiple ways of creating these virtual environments a
2424

2525
## Considered Options
2626

27-
There are (unfortunately) multiple tools to manage package dependencies in Python, for example, listed [here](https://packaging.python.org/en/latest/tutorials/managing-dependencies/#other-tools-for-application-dependency-management) and [here](https://python.libhunt.com/poetry-alternatives). There are also comparison sites like [this](https://ritza.co/articles/gen-articles/pipenv-vs-virtualenv-vs-poetry-vs-pyenv-vs-pip/), [this](https://www.warp.dev/blog/prose-about-poetry), [this](https://dev.to/adamghill/python-package-manager-comparison-1g98), and [this](https://dev.to/frostming/a-review-pipenv-vs-poetry-vs-pdm-39b4) that go into more detail about many of these tools, as well as some descriptive statistics of the popularities of each [here](https://python.libhunt.com/poetry-alternatives).
27+
There are (unfortunately) multiple tools to manage package dependencies in Python, for example, listed at [Python Packaging User Guide](https://packaging.python.org/en/latest/tutorials/managing-dependencies/#other-tools-for-application-dependency-management) and at [Awesome Python](https://python.libhunt.com/poetry-alternatives). There are also comparison sites like [Ritza Articles](https://ritza.co/articles/gen-articles/pipenv-vs-virtualenv-vs-poetry-vs-pyenv-vs-pip/), [warp](https://www.warp.dev/blog/prose-about-poetry), and [this](https://dev.to/adamghill/python-package-manager-comparison-1g98), and [this](https://dev.to/frostming/a-review-pipenv-vs-poetry-vs-pdm-39b4) at [dev.to](https://dev.to/) that go into more detail about many of these tools.
2828

2929
We'll only cover:
3030

@@ -35,7 +35,7 @@ We'll only cover:
3535

3636
### Pipenv
3737

38-
Was designed to combine the functionality of `pip` and `virtualenv`.
38+
[Pipenv](https://pipenv.pypa.io/en/latest/index.html) was designed to combine the functionality of `pip` and `virtualenv`.
3939

4040
- **Pros**:
4141
- Fairly popular
@@ -89,9 +89,9 @@ Was designed to combine the functionality of `pip` and `virtualenv`.
8989

9090
## Decision Outcome
9191

92-
We decided on Poetry because it has amazing documentation, is well designed, and is very popular and widely used.
92+
We decided on Poetry because it has amazing documentation, is well-designed, and is very popular and widely used.
9393

9494
### Consequences
9595

96-
- Because it isn't fully PEP compliant, we might encounter some issues
97-
- Doesn't have the "official" support that Hatch has, so we might reconsider the decision to use Poetry at a future date
96+
- Because Poetry isn't fully PEP compliant, we might encounter some issues
97+
- Doesn't have the "official" support (maintenance by PyPA) that Hatch has, so we might reconsider the decision to use Poetry at a future date

0 commit comments

Comments
 (0)