Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome-to-linux directory #5

Merged

Conversation

SorinAlexB
Copy link
Member

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Transitioned the 'welcome-to-linux' directory to meet the requirements of the OpenEdu Methodology.

@SorinAlexB SorinAlexB requested review from teodutu and AdoX13 June 17, 2024 21:55
@github-actions github-actions bot added area/drills Update to drills content area/infra Update to infrastructure area/reading Update to reading content topic/scratch-linux Related to the "Scratch Linux" chapter area/guides Update to guides content kind/improve Improve / Update existing content / item kind/new New content / item labels Jun 18, 2024
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered labels Jun 18, 2024
Copy link

1 similar comment
Copy link

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look OK overall. I made some small inline suggestions. besides those:

  • Remove the "Challenge" and "Tutorial" prefixes from the names of each exercise.
  • Fix the failing CI/CD tests (including deployment) [1]. To fix spellcheck, you'll have to add some words or acronyms to these lists [2]. Make another PR to that repo with the added words. Make sure to run sort -u -o <file_name> <file_name>.

PR rendering isn't working yet. I'll fix the published link.

[1] https://github.com/security-summer-school/essentials-security/pull/5/checks
[2] https://github.com/open-education-hub/actions/tree/main/spellcheck/config

@SorinAlexB SorinAlexB force-pushed the migrate_welcome-to-linux branch from 610f683 to 7b39daa Compare June 22, 2024 13:23
Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the linter errors [1] [2] and reword your commit like so: welcome-to-linux: Rework session according to OpenEdu methodology then add a description of the changes to it. To fix [2], you'll have to make a PR with the missing words here [3]

[1] https://github.com/security-summer-school/essentials-security/actions/runs/9625815290/job/26551093380?pr=5
[2] https://github.com/security-summer-school/essentials-security/actions/runs/9625815290/job/26551093277?pr=5
[3] https://github.com/open-education-hub/actions

@SorinAlexB SorinAlexB force-pushed the migrate_welcome-to-linux branch 4 times, most recently from ddd69fd to f77eb23 Compare June 23, 2024 22:37
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Jun 24, 2024
Copy link

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to split the reading material into subchapters and we can merge this. Everything else seems fine.

@SorinAlexB SorinAlexB force-pushed the migrate_welcome-to-linux branch from f77eb23 to 0be9d7d Compare June 24, 2024 08:05
Transitioned the 'welcome-to-linux' directory to meet the requirements of
the OpenEdu Methodology.

Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
@SorinAlexB SorinAlexB force-pushed the migrate_welcome-to-linux branch from 0be9d7d to 669ffb9 Compare June 24, 2024 08:17
@SorinAlexB SorinAlexB requested a review from teodutu June 24, 2024 08:19
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Jun 24, 2024
Copy link

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@teodutu teodutu merged commit 81171bb into security-summer-school:main Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drills Update to drills content area/guides Update to guides content area/infra Update to infrastructure area/reading Update to reading content kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/scratch-linux Related to the "Scratch Linux" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants