-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update welcome-to-linux directory #5
Update welcome-to-linux directory #5
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look OK overall. I made some small inline suggestions. besides those:
- Remove the "Challenge" and "Tutorial" prefixes from the names of each exercise.
- Fix the failing CI/CD tests (including deployment) [1]. To fix spellcheck, you'll have to add some words or acronyms to these lists [2]. Make another PR to that repo with the added words. Make sure to run
sort -u -o <file_name> <file_name>
.
PR rendering isn't working yet. I'll fix the published link.
[1] https://github.com/security-summer-school/essentials-security/pull/5/checks
[2] https://github.com/open-education-hub/actions/tree/main/spellcheck/config
chapters/scratch-linux/welcome-to-linux/drills/tasks/in-your-face/README.md
Outdated
Show resolved
Hide resolved
chapters/scratch-linux/welcome-to-linux/drills/tasks/jumbled/README.md
Outdated
Show resolved
Hide resolved
610f683
to
7b39daa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the linter errors [1] [2] and reword your commit like so: welcome-to-linux: Rework session according to OpenEdu methodology
then add a description of the changes to it. To fix [2], you'll have to make a PR with the missing words here [3]
[1] https://github.com/security-summer-school/essentials-security/actions/runs/9625815290/job/26551093380?pr=5
[2] https://github.com/security-summer-school/essentials-security/actions/runs/9625815290/job/26551093277?pr=5
[3] https://github.com/open-education-hub/actions
ddd69fd
to
f77eb23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only need to split the reading material into subchapters and we can merge this. Everything else seems fine.
f77eb23
to
0be9d7d
Compare
Transitioned the 'welcome-to-linux' directory to meet the requirements of the OpenEdu Methodology. Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
0be9d7d
to
669ffb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Prerequisite Checklist
Description of changes
Transitioned the 'welcome-to-linux' directory to meet the requirements of the OpenEdu Methodology.