Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arrow func test error when global variable initialized uncorrectly #426

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jingshi-ant
Copy link
Collaborator

reason: TrimOptions/SliceOptions should not be global variables, which depend on other static variables to be initialized earlier.

@jingshi-ant jingshi-ant requested a review from tongke6 December 24, 2024 07:30
Copy link
Collaborator

@tongke6 tongke6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tongke6 tongke6 merged commit 90a3d1e into main Dec 24, 2024
10 checks passed
@tongke6 tongke6 deleted the jingshi/fix-engine-ut branch December 24, 2024 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants