Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base time option #7

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Add base time option #7

merged 1 commit into from
Nov 23, 2024

Conversation

m-mizutani
Copy link
Contributor

This pull request introduces several enhancements and bug fixes to the hatchery package, focusing on adding timestamp functionality, improving logging, and modifying configurations for the Slack source. The most important changes include adding a base time flag, updating log messages to include the base time, and modifying the limit configuration for Slack API requests.

Enhancements to timestamp functionality:

  • cli.go: Added a base-time flag to the CLI for specifying a base time, with the default being the current time. This flag is injected into the context if provided. [1] [2] [3] [4]

Improvements to logging:

Modifications to Slack source configuration:

  • source/slack/slack.go: Increased the default Limit value from 100 to 1000 and updated the WithLimit function to handle zero or negative values by excluding the limit parameter from the request. [1] [2] [3]

@m-mizutani m-mizutani merged commit 316a78c into main Nov 23, 2024
4 checks passed
@m-mizutani m-mizutani deleted the feature/base-time branch November 23, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant