Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more search capabilities #80

Open
melyshu opened this issue Apr 29, 2017 · 4 comments
Open

more search capabilities #80

melyshu opened this issue Apr 29, 2017 · 4 comments
Assignees

Comments

@melyshu
Copy link
Collaborator

melyshu commented Apr 29, 2017

I'm thinking:

'1xx', '2xx', '3xx', '4xx', '5xx' to detect 100/200/300/400/500 level classes. These should OR like other fields (i.e. a search of 'cos 1xx 2xx' should return all 100 and 200 level cos courses)

'm', 'tu', 'w', 'th', 'f' or something similar to search for classes within those days. As above, these should OR like other fields so that a search of 'cos m w th' should return all cos courses whose classes are on monday, wednesday, or thursday. (probably makes sense to find classes that fit within the days rather than an exact match)

(stretch) maaaaaaybe some time restrictions: '8a', '9a', '10a', ... to represent the hours 8am-9am, 9am-10am, 10am-11am etc. These should OR like other fields, so that 't th 8a 9a 10a' should search for all classes held within 8am-11am on tuesdays and thursdays. One decision to make if implemented - do we restrict just on the lecture time or all section times (maybe put the times into course clash??)

In terms of informing the user about these search features, I'm working on the suggest pane. It will (hopefully) be intuitive how these search queries work from the way they're displayed there.

@melyshu
Copy link
Collaborator Author

melyshu commented Apr 30, 2017

more thoughts on modularizing search fields:

pdf options should all OR like other fields (i.e. 'pdfo npdf' should yield all pdf only and all npdf courses). maybe add a 'pdfx' option for those courses that don't have pdf data

audit options: include a 'naudit' for completeness' sake. OR as above. (potentially 'auditx' for those courses that don't have audit data... if there are any?)

(maybe) consider filtering by rating as well: {1.x, 2.x, 3.x, 4.x, x.x} or {1+, 2+, 3+, 4+, n/a} or similar (the current 'new' badge would fit into this category). OR as above.

sebthedev pushed a commit that referenced this issue May 2, 2017
sebthedev pushed a commit that referenced this issue May 2, 2017
@sebthedev
Copy link
Owner

  • Searching by catalog number level (1xx, 3xx, etc…) now implemented on the backend.
  • Searching for NAUDIT now implemented on the backend.

@sebthedev
Copy link
Owner

Filtering based on when the course meets (either by day of the week or by time) is both complicated to implement and difficult to define what the "correct" implementation is.

If a user searches for m w does this mean…

  • Return all courses that have have any class on Monday or Wednesday
  • Return all courses that have have all of their classes on Monday or Wednesday
  • Return all courses that have have all of their lectures on Monday or Wednesday
  • Or any other reasonable implementation…

Thoughts?

@melyshu
Copy link
Collaborator Author

melyshu commented May 2, 2017

I agree that this is not well defined... but I think the most intuitive implementation would be to return all classes that have their main section(s) (lecture/seminar/whatever) within the specified days. At a first glance this is what it seems like the registrar's site is doing, and it'd probably be good to implement search-by-days in a way that is consistent with their search?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants