-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not initialize lazy objects during export #69
Do not initialize lazy objects during export #69
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 60 61 +1
===========================================
Files 1 1
Lines 185 186 +1
===========================================
+ Hits 185 186 +1 ☔ View full report in Codecov by Sentry. |
e20a38f
to
5446448
Compare
5446448
to
9c05000
Compare
May I ask you to target the |
it seems that the problem does not exist in |
static analysis seems to not understand new php 8.4 lazy stuff 😆 |
Yes, PHPStan runs on PHP 8.4 but does not yet supports its features. @staabm and @ondrejmirtes are workin on it :) I will take care of ignoring the "issues" in the meantime. |
Okay, thanks! |
83e92a6
into
sebastianbergmann:main
Adding support for PHP 8.4 is gradual. PHPStan already knows about new functions and methods added in PHP 8.4, here's proof: https://phpstan.org/r/22140ef9-ff53-4a33-9655-e8248d342619 I haven't checked precisely but my estimate is that it knows about The biggest amount of work are going to be property hooks, they will take some time to be implemented :) |
Reason behind this is that if a dataprovider is passed a php 8.4 lazy proxy, the "lazyness" is lost, because of
ReflectionObject()->getProperties()
, see https://www.php.net/manual/en/language.oop5.lazy-objects.php#language.oop5.lazy-objects.initialization-triggers