Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable symbolic indexing for PEtab results? #173

Open
TorkelE opened this issue Feb 16, 2024 · 2 comments
Open

Enable symbolic indexing for PEtab results? #173

TorkelE opened this issue Feb 16, 2024 · 2 comments
Milestone

Comments

@TorkelE
Copy link
Contributor

TorkelE commented Feb 16, 2024

Just writing stuff here as I get ideas, feel free to close/consolidate to single issues if easier to handle that way.

It could be neat to permit accessing a parameters (optimal) value from a PEtab result like:

res = calibrate_model_multistart(petab_problem, ...)
res[p1]

to get its value.

Long-term, if rerouting through OptimizationProblems this would be handled automatically. However, it seems unlikely that SciML/Optimization will have full support for desired stuff (e.g. saving traces for plotting) any time soon.

@sebapersson
Copy link
Owner

I think this would be great. Will have it on the TODO for v3.0.

@sebapersson sebapersson added this to the 3.0 milestone Apr 26, 2024
@sebapersson
Copy link
Owner

sebapersson commented Sep 30, 2024

I wonder if we need this anymore. Now PEtabOptmizationResult as well as PEtabMultistartResult output the result as a ComponentArray. This means that fitted parameters can be accessed as:

xmin = res.xmin
k2 = xmin[:k2] # or xmin.k2

What do you think? Maybe it is better to rather add a get_xmin function (where the user can also choose which scale to convert the parameters to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants