-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting PEtab select and Catalyst models #108
Comments
I agree support for PEtab-select with Catalyst model would be great addition. Briefly, PEtab-select allows model selection over a parameter space - where for each parameter in the parameter space the user can specify if they want to fixate a parameter to a value, or if it should be estimated. Then different methods like backward or forward selection can be used. Currently for all bookkeeping (generating candidate models) we use the petab-select python package. I like your suggestion with reactions, to connect with PEtab select we would also need to allow the user (for each reaction) if optional to provide potentially fixated value for the parameters governing said reaction. Maybe, it could be good to allow the user to also provide, as an alternative to reactions, parameters to perform the selection over? |
Sounds good. Next time we have a chat we could discuss further. |
Sounds good to me, selecting reactions is an intuitive way to see model selection with CRN-based models. As you have just one parameter per reaction in your example, specifying the model space in terms of reactions or parameters is equivalent. Supporting the specification of the model space in terms of both makes sense -- the former for intuitiveness, the latter as this is what PEtab Select is designed for. In the case where you want to disable a reaction that involves multiple parameters, then you might want to add some "indicator" binary parameter to each reaction, such that PEtab Select can toggle groups of parameters on or off. At the moment, PEtab Select supports groups of parameters only via multiple rows in the model space. However, I see that being able to toggle groups of parameters on or off with meta grouping parameters would be a helpful addition. Here's one possible workflow
- reaction_r1:
- k1
- reaction_r2:
- k2a
- k2b and the standard PEtab Select model space file, but now with the metaparameters
There are some open issues with the above still, e.g. the user has no control over which reactions are in the model selection problem, and the user isn't able to fix e.g. |
Thanks a lot for the input @dilpath - I like the workaround with an indicator (which I also see as quite straightforward to implement and workarounds can be found for cases like I will discuss this with Torkel next week, and then setup a first draft, would be great to have your input on this draft. |
It would be neat if one could integrate PEtab select's feature for model selection with models declared in Catalyst (similar as was done for normal PEtab models).
I am not fully familiar with PEtab select, but would something like this make sense?
Here, the user provides similar data as for creating a
PEtabModel
fromrn
using the Catalyst route. Next one supply a list of candidate reactions (stored inreactions
) on which to run PEtab select.Are there some additional points I am missing, and would this make sense to support?
The text was updated successfully, but these errors were encountered: