make ARM+ARM_HYP proofs work for smaller irq_len #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corlewis
reviewed
Dec 9, 2024
Comment on lines
+302
to
+304
| (* if irq_len < 8, there may be an additional term in the goal *) | ||
| apply (rule conjI, word_eqI_solve)? | ||
| apply (word_eqI_solve dest: bit_imp_le_length) |
There was a problem hiding this comment.
Oh, this is a clever way to handle this. Thanks for the comment, it would have been very confusing without it
corlewis
approved these changes
Dec 9, 2024
The example assumes an irq type of at least 8 bits. Some AArch32 boards only use 7 bit. Use smaller numbers in the example so that the example happens to work on those boards as well. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Remove remaining use of direct numeral related to irq_len. The lemma happened to work for irq_len >= 8, but not for smaller irq_len. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove remaining use of direct numeral related to
irq_len. The lemma happened to work forirq_len >= 8, but not for smallerirq_len.Improve sys-init example: the example assumes an irq type of at least 8 bits. Some AArch32 boards only use 7 bit. Use smaller numbers in the example so that the example happens to work on those boards as well.