Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress simplifier warnings in corres_rewrite #705

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jan 12, 2024

  • add a method for setting context visibility to false for Eisabach methods
  • use it in simpl_rewrite to suppress simplifier warnings in ccorres_rewrite

This should make ccorres_rewrite quite about Collect_const being in the simpset or not.

lsf37 added 2 commits January 13, 2024 10:22
Contexts have the "visible" flag that determine whether warnings such
as duplicate rewrite rules are shown or not. Make setting this flag to
false available in Eisbach methods.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
This gets rid of the simplified warning for Collect_const that
ccorres_rewrite produces in many CRefine proofs.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
@lsf37 lsf37 added the proof tools convenience, automation, productivity tools label Jan 12, 2024
@lsf37 lsf37 self-assigned this Jan 12, 2024
Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be also be useful in ccorres_rewrite and the duplicate simp rule warning

@lsf37 lsf37 merged commit 449cfc7 into master Jan 15, 2024
13 of 14 checks passed
@lsf37 lsf37 deleted the quiet_corres_rewrite branch January 15, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proof tools convenience, automation, productivity tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants