Speed up test_benchmark_single_table_realtabformer_no_metrics integration test
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
commented
Feb 10, 2025
| @@ -19,6 +20,7 @@ | |||
| 'TVAESynthesizer': TVAESynthesizer, | |||
| 'PARSynthesizer': PARSynthesizer, | |||
| 'HMASynthesizer': HMASynthesizer, | |||
| 'RealTabFormerSynthesizer': RealTabFormerSynthesizer, | |||
There was a problem hiding this comment.
Changes to make create_sdv_synthesizer_variant work with RealTabFormerSynthesizer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 65.87% 65.95% +0.07%
==========================================
Files 20 20
Lines 1304 1307 +3
==========================================
+ Hits 859 862 +3
Misses 445 445
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fealho
requested review from
gsheni,
amontanez24,
a team and
lajohn4747
and removed request for
a team and
gsheni
amontanez24
approved these changes
Feb 10, 2025
lajohn4747
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b3uhn4q, Resolve #379.
This PR speeds up the test from ~4min to ~30s on my M1 Mac.