-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the ColumnSynthesizer
follow the sdtypes in the metadata (not the data's dtypes)
#374
Conversation
a618035
to
2564a8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 65.36% 65.74% +0.37%
==========================================
Files 20 20
Lines 1282 1299 +17
==========================================
+ Hits 838 854 +16
- Misses 444 445 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have one comment about this PR, also are there failing test checks a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just let a comment about handling the new Metadata
object
CU-85zt7j8em, Resolve #249.