Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ColumnSynthesizer follow the sdtypes in the metadata (not the data's dtypes) #374

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

fealho
Copy link
Member

@fealho fealho commented Jan 21, 2025

CU-85zt7j8em, Resolve #249.

@sdv-team
Copy link
Contributor

@fealho fealho force-pushed the issue-249-column-synthesizer branch from a618035 to 2564a8a Compare January 21, 2025 03:50
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (241719b) to head (aa50092).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdgym/synthesizers/column.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   65.36%   65.74%   +0.37%     
==========================================
  Files          20       20              
  Lines        1282     1299      +17     
==========================================
+ Hits          838      854      +16     
- Misses        444      445       +1     
Flag Coverage Δ
integration 53.88% <82.35%> (+0.37%) ⬆️
unit 52.88% <82.35%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review January 21, 2025 04:57
@fealho fealho requested a review from a team as a code owner January 21, 2025 04:57
@fealho fealho requested review from gsheni, lajohn4747 and R-Palazzo and removed request for a team and gsheni January 21, 2025 04:57
Copy link
Contributor

@lajohn4747 lajohn4747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one comment about this PR, also are there failing test checks a problem?

@fealho fealho requested a review from lajohn4747 January 22, 2025 16:30
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just let a comment about handling the new Metadata object

@fealho fealho requested a review from R-Palazzo January 22, 2025 18:38
@fealho fealho merged commit f992575 into main Jan 23, 2025
35 of 47 checks passed
@fealho fealho deleted the issue-249-column-synthesizer branch January 23, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ColumnSynthesizer should follow the sdtypes in the metadata (not the data's dtypes)
4 participants