Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radec issue206 #207

Merged
merged 4 commits into from
Apr 3, 2025
Merged

Fix radec issue206 #207

merged 4 commits into from
Apr 3, 2025

Conversation

ymamay
Copy link
Contributor

@ymamay ymamay commented Mar 21, 2025

Updated the headers so it now has the astrometric RA, dec, and PA for SCI, SkyE, SkyW and changed header keyword names and comments to reflect this (was IFUCEN*, now {TEL})
Updated the drpall file (and test) so it now pulls the RA and Dec from these 'best' ones instead of TE

Updated the sky header calculations to also use the 'best' ones instead of TERA, TEDE
Addresses Git Issue 206

@ymamay ymamay requested a review from ajmejia as a code owner March 21, 2025 16:25
@ymamay ymamay requested review from havok2063 and ajmejia and removed request for ajmejia March 21, 2025 16:25
@havok2063 havok2063 self-requested a review April 3, 2025 19:19
Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ymamay ymamay merged commit 711ebbb into master Apr 3, 2025
8 checks passed
@ymamay ymamay deleted the fix_radec_issue206 branch April 3, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants