GUI: advanced option to enable training-time upsampling so that it is compatible with all training WAVs #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honkkis
changed the title
…ger times upsampling." This reverts commit b449402.
|
Reverted back to using scipy's resample since that shows very clean spectrogram with no content above nyquist 24kHz after resampling to 96 kHz. This was not the case with linear upsampling. |
|
Thanks for the PR. Like I said in my response in #355, this isn't the direction I'm currently looking to take NAM's standardized trainer, but it's a cool piece of work nonetheless 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think I found a good way to allow antialiasing geeks like me to do training-time upsampling. The key idea is to do the upsampling in memory after the wavs have been loaded, validated, and split.
This pull request fixes #355 .
Please merge to main branch or let me know if something needs to be fixed to be compliant to main. Unit tests pass.
Benefits shown in these spectrograms: