You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Running nam in a fresh venv fails:
Traceback (most recent call last):
File "/home/barabas/data3/projects/software/nam/.venv/bin/nam", line 5, in <module>
from nam.cli import nam_gui
File "/home/barabas/data3/projects/software/nam/trainer-repo/nam/__init__.py", line 26, in <module>
from . import train # noqa F401
^^^^^^^^^^^^^^^^^^^
File "/home/barabas/data3/projects/software/nam/trainer-repo/nam/train/__init__.py", line 11, in <module>
from . import gui # noqa F401
^^^^^^^^^^^^^^^^^
File "/home/barabas/data3/projects/software/nam/trainer-repo/nam/train/gui/__init__.py", line 15, in <module>
import requests as _requests
To Reproduce
Steps to reproduce the behavior:
Create a new venv and activate it
Install pytorch with ROCm using pip from upstream: https://pytorch.org/get-started/locally/. It seems like ROCm is not supported in pypi or conda pytorch packages and the docs don't have any advice for AMD GPU users, so I used AMD's docs to set it up.
Install NAM for development with pip: pip install -e trainer-repo
Run nam
After manually installing requests, there is another import error:
$ nam
Traceback (most recent call last):
File "/home/barabas/data3/projects/software/nam/.venv/bin/nam", line 5, in <module>
from nam.cli import nam_gui
ImportError: cannot import name 'nam_gui' from 'nam.cli' (/home/barabas/data3/projects/software/nam/trainer-repo/nam/cli.py)
$ grep "nam_gui" nam/cli.py
from nam.train.gui import run as _nam_gui # noqa F401 Used as an entry point
Looks like the main branch is not in a working state at the moment.
Expected behavior nam runs after installation
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: Arch linux
Are you running locally or is this somethig that happens on Colab? Locally
@Barabas5532 thanks for the Issue. I've pushed changes that fix the issue locally on my MacBook Pro, and some other issues identified by CI/CD have been fixed as well.
Can you pull the latest from main and let me know if it resolves your issue?
Describe the bug
Running
nam
in a fresh venv fails:To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/sdatkinson/neural-amp-modeler.git trainer-repo
pip install -e trainer-repo
nam
After manually installing requests, there is another import error:
Looks like the main branch is not in a working state at the moment.
Expected behavior
nam
runs after installationScreenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
requests should be a regular dependency for the project, not a test dependency since it's used in https://github.com/sdatkinson/neural-amp-modeler/blob/main/nam/train/gui/__init__.py
The text was updated successfully, but these errors were encountered: