Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ConcatDataset doesn't implement sample_rate property #530

Open
sdatkinson opened this issue Feb 2, 2025 · 0 comments
Open

[BUG] ConcatDataset doesn't implement sample_rate property #530

sdatkinson opened this issue Feb 2, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers priority:low Low-priority issues

Comments

@sdatkinson
Copy link
Owner

Dataset.sample_rate:

neural-amp-modeler/nam/data.py

Line 383 in af1c4d5

def sample_rate(self) -> _Optional[float]:

Feels like it'd be wise to implement this for ConcatDataset (perhaps impose as a property of _AbstractDataset).

Without validation, e.g.:

def sample_rate(self):
  return self.datasets[0].sample_rate
@sdatkinson sdatkinson added bug Something isn't working priority:low Low-priority issues good first issue Good for newcomers labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers priority:low Low-priority issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdatkinson