Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Query Paging #1238

Open
wants to merge 6 commits into
base: branch-hackathon
Choose a base branch
from
Open

tests: Query Paging #1238

wants to merge 6 commits into from

Conversation

CodeLieutenant
Copy link

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@CodeLieutenant
wip
ae3e14c 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant
wip
a40432f 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 3cd709b

@CodeLieutenant
wip
6251b95 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant
wip
6d77a91 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant
wip
227d18b 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant
wip
3cd709b 
Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant CodeLieutenant marked this pull request as ready for review February 13, 2025 15:57
@wprzytula
Copy link
Collaborator

Why are we supposed to review 6 commits, each named "wip"? Please provide a cover letter and reasonable commit division first.

@CodeLieutenant
Copy link
Author

Why are we supposed to review 6 commits, each named "wip"? Please provide a cover letter and reasonable commit division first.

Yes I will rewrite them, just wanted to fix any changes before doing that

@CodeLieutenant CodeLieutenant changed the title feature(integration-tests): Query Paging Tests tests: Query Paging Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wprzytula wprzytula Awaiting requested review from wprzytula

@Lorak-mmk Lorak-mmk Awaiting requested review from Lorak-mmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeLieutenant @wprzytula