Fix duration marshal, unmarshall functions
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-li
force-pushed
the
il/fix/marshal/duration
branch
from
8ec91c8 to
97fd1f7
Compare
Changes: 1. Unmarshalling into `int64`,`custom int64`,`time.Duration`,`string` and `custom string`, was unsupported before, now is supported. 2. Marshalling are `custom string`, `custom int64` was unsupported before, now is supported. 3. Unmarshalling `broken data` does not return an error before, now returns an error.
illia-li
force-pushed
the
il/fix/marshal/duration
branch
from
97fd1f7 to
b977347
Compare
dkropachev
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
int64,custom int64,time.Duration,stringandcustom stringwas unsupported before, now is supported.custom string,custom int64was unsupported before, now is supported.broken datadoes not return an error before, now returns an error.big datadoes not return an error before, now returns an error.