Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch for issue #49 and fixed Travis tests #119

Merged
merged 2 commits into from
Nov 28, 2019
Merged

patch for issue #49 and fixed Travis tests #119

merged 2 commits into from
Nov 28, 2019

Conversation

marekyggdrasil
Copy link
Contributor

As suggested in #49 (comment)

@marekyggdrasil marekyggdrasil changed the title patch for issue #49 patch for issue #49 and fixed Travis tests Nov 27, 2019
@marekyggdrasil
Copy link
Contributor Author

Hi @ruairif, I tag you because I see you authored the last commit, do you have rights to merge this PR? I made a patch for issue #49 and also fixed the .travis.yml so now build is passing on all envs.

@ruairif ruairif merged commit 31b5881 into scrapy:master Nov 28, 2019
@ruairif
Copy link
Collaborator

ruairif commented Nov 28, 2019

Thanks @marekyggdrasil for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekyggdrasil @ruairif