Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the argument in super().__init__() within SplashAwareDupeFilter's __init__() #328

Merged

Conversation

protokoul
Copy link
Contributor

Submitting this PR to resolve a bug highlighted here #322 (comment). RFPDupeFilter's __init__() implements fingerprinter as a keyword-only argument.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.18%. Comparing base (d763eb7) to head (159dc60).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scrapy_splash/dupefilter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files           9        9           
  Lines         681      681           
  Branches      125      125           
=======================================
  Hits          621      621           
  Misses         36       36           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio merged commit b8c415a into scrapy-plugins:master Feb 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants