Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .dockerignore, add docker run and go vet tests in CI #55

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

Added files that were missing in .dockerignore..

Description

while building the image we did not see the score-k8s at his full potential, so after adding the rest of the file it works fine..

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the catch of error if the container is not built/running properly.

mathieu-benoit and others added 5 commits October 16, 2024 07:35
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit mathieu-benoit changed the title Fix docker ignore Fix .dockerignore, add docker run and go vet tests in CI Oct 16, 2024
@mathieu-benoit mathieu-benoit merged commit d94aa99 into score-spec:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants