Function tag.sh doe not export IMAGE_NAME #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ob/master/tag.sh does not export IMAGE_NAME. The variable is mandatory. Instead of it let's get it from <version>/.image-id file Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
We do not need environment variable IMAGE_NAME at all. This is already implement e.g. here: https://github.com/sclorg/container-common-scripts/blob/master/tag.sh#L33 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script tag.sh https://github.com/sclorg/container-common-scripts/blob/master/tag.sh does not export
IMAGE_NAME variable. Later on we would like to replace building containers by Python class and this could be a last but not
the first step of migration.
The variable is mandatory.
Instead of it let's get it from /.image-id file