Fix SA in shared inventories [SCI-11513] #8196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoscinote
requested changes
Jan 30, 2025
| end | ||
|
|
||
| def validate_tsk_permissions(user, team, object) | ||
| can_read_my_module?(user, object) && validate_exp_permissions(user, team, object.experiment) | ||
| MyModule.viewable_by_user(user, team).find_by(id: object.id).present? |
There was a problem hiding this comment.
replace .find_by(id: object.id).present? with exists?(id: object.id)
aignatov-bio
force-pushed
the
ai-sci-11513-smart-annotations-in-shared-inventory
branch
from
70ef3d3 to
39948d6
Compare
aignatov-bio
changed the base branch from
features/small-improvements
to
develop
artoscinote
approved these changes
Jan 30, 2025
artoscinote
requested changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-11513
What was done
Fix SA in shared inventories