more useful warnings and errors #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schombert
reviewed
Dec 2, 2023
| @@ -2973,7 +2977,7 @@ struct effect_body { | |||
| else if(context.from_slot == trigger::slot_contents::province) | |||
| context.compiled_effect.push_back(effect::remove_casus_belli_from_province); | |||
| else { | |||
| err.accumulated_errors += "remove_casus_belli = from effect used in an incorrect scope type (" + err.file_name + | |||
| err.accumulated_errors += "remove_casus_belli = from effect used in an incorrect scope type " + slot_contents_to_string(context.main_slot) + " (" + err.file_name + | |||
There was a problem hiding this comment.
so, I will merge this pr, because it probably won't hurt anything, but note that some of these errors, such as this one in particular, can come from mismatches in scopes other than the main one, in which case displaying the main one, which may very well make sense, is probably going to be even more confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.