Factory potentials & Economies of scale for factories #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ineveraskedforthis you probably want to review this |
schombert
reviewed
Feb 6, 2025
|
|
||
| auto const tax_eff = nations::tax_efficiency(state, n); | ||
| auto const rich_effect = (1.0f - tax_eff * float(state.world.nation_get_rich_tax(n)) / 100.0f); | ||
|
|
||
| if(desired_types.empty()) { | ||
| for(auto type : state.world.in_factory_type) { | ||
| if(n.get_active_building(type) || type.get_is_available_from_start()) { | ||
| if(command::can_begin_factory_building_construction(state, nid, sid, type, false) || command::can_begin_factory_building_construction(state, nid, sid, type, true)) { |
There was a problem hiding this comment.
@SneakBug8 This is changing a very cheap check into two very expensive checks. If the expensive checks are necessary, the code should be written so that they are taken a minimal number of times (for example, it shouldn't be doing duplicate work checking for both upgrades and new construction)
schombert
reviewed
Feb 6, 2025
| @@ -467,6 +467,11 @@ object { | |||
| type{ bitfield } | |||
| tag{ scenario } | |||
| } | |||
| property{ | |||
| name{ uses_potentials } | |||
There was a problem hiding this comment.
why is this being stored in the factory type when everything else is tied to the commodity? I don't think that your syntax for this feature allows it to attach to some factory types and not others if they happen to produce the same output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.