Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only rebuild scene graph once per Renderer frame #594

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

kephale
Copy link
Member

@kephale kephale commented May 29, 2024

Previously each node deletion would trigger a scene graph rebuild. This change adds a flag that triggers a scene graph rebuild only once per frame.

Closes #578

@kephale
Copy link
Member Author

kephale commented Jun 9, 2024

@skalarproduktraum I'd like to close this, but will sit on it for a few days. If there are no replies i'll assume alles gut and will merge next time i revisit.

@kephale kephale merged commit 4c29759 into main Jun 13, 2024
3 of 4 checks passed
@kephale kephale deleted the fix-scene-rebuilds branch June 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a group to a Volume and then removing the group doesn't update the object inspector.
1 participant