Disable adapter support (not implemented in huggingfaceserver yet)

scc-digitalhub · Aug 29, 2024 · 2af53b8 · 2af53b8
1 parent 7512aa5
commit 2af53b8
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 35 deletions.
diff --git a/...ve/src/main/java/it/smartcommunitylabdhub/runtime/huggingface/HuggingfaceServeRunner.java b/...ve/src/main/java/it/smartcommunitylabdhub/runtime/huggingface/HuggingfaceServeRunner.java
@@ -181,33 +181,32 @@ public K8sRunnable produce(Run run) {
             args.add(taskSpec.getDtype().getDType());
         }
 
-        if (functionSpec.getAdapters() != null && functionSpec.getAdapters().size() > 0) {
-            contextRefs = new LinkedList<>(contextRefs);
-            args.add("--enable-lora");
-            args.add(Boolean.TRUE.toString());
-            args.add("--lora-modules");
-
-            for (Map.Entry<String, String> adapter : functionSpec.getAdapters().entrySet()) {
-                UriComponents adapterUri = UriComponentsBuilder.fromUriString(adapter.getValue()).build();
-                String adapterSource = adapter.getValue().trim();
-                String ref = adapterSource;
+        // if (functionSpec.getAdapters() != null && functionSpec.getAdapters().size() > 0) {
+        //     contextRefs = new LinkedList<>(contextRefs);
+        //     args.add("--enable-lora");
+        //     args.add("--lora-modules");
+
+        //     for (Map.Entry<String, String> adapter : functionSpec.getAdapters().entrySet()) {
+        //         UriComponents adapterUri = UriComponentsBuilder.fromUriString(adapter.getValue()).build();
+        //         String adapterSource = adapter.getValue().trim();
+        //         String ref = adapterSource;
 
-                if (!"huggingface".equals(adapterUri.getScheme())) {
-                    if (!adapterSource.endsWith("/")) adapterSource += "/";
-                    ref = "/shared/adapters/" + adapter.getKey() + "/";
-                    contextRefs =
-                        Collections.singletonList(
-                            ContextRef
-                                .builder()
-                                .source(adapterSource)
-                                .protocol(adapterUri.getScheme())
-                                .destination("adapters/" + adapter.getKey())
-                                .build()
-                        );
-                }
-                args.add(adapter.getKey() +  "=" + ref);
-            }
-        }
+        //         if (!"huggingface".equals(adapterUri.getScheme())) {
+        //             if (!adapterSource.endsWith("/")) adapterSource += "/";
+        //             ref = "/shared/adapters/" + adapter.getKey() + "/";
+        //             contextRefs =
+        //                 Collections.singletonList(
+        //                     ContextRef
+        //                         .builder()
+        //                         .source(adapterSource)
+        //                         .protocol(adapterUri.getScheme())
+        //                         .destination("adapters/" + adapter.getKey())
+        //                         .build()
+        //                 );
+        //         }
+        //         args.add(adapter.getKey() +  "=" + ref);
+        //     }
+        // }
 
         CorePort servicePort = new CorePort(HTTP_PORT, HTTP_PORT);
         CorePort grpcPort = new CorePort(GRPC_PORT, GRPC_PORT);

diff --git a/...java/it/smartcommunitylabdhub/runtime/huggingface/specs/HuggingfaceServeFunctionSpec.java b/...java/it/smartcommunitylabdhub/runtime/huggingface/specs/HuggingfaceServeFunctionSpec.java
@@ -24,17 +24,17 @@
 )
 public class HuggingfaceServeFunctionSpec extends ModelServeFunctionSpec {
 
-    @JsonProperty("adapters")
-    @Schema(title = "fields.huggingface.adapters.title", description = "fields.huggingface.adapters.description")
-    private Map<String, String> adapters;
+    // @JsonProperty("adapters")
+    // @Schema(title = "fields.huggingface.adapters.title", description = "fields.huggingface.adapters.description")
+    // private Map<String, String> adapters;
 
-    @Override
-    public void configure(Map<String, Serializable> data) {
-        super.configure(data);
+    // @Override
+    // public void configure(Map<String, Serializable> data) {
+    //     super.configure(data);
 
-        HuggingfaceServeFunctionSpec spec = mapper.convertValue(data, HuggingfaceServeFunctionSpec.class);
-        this.adapters = spec.getAdapters();
-    }
+    //     HuggingfaceServeFunctionSpec spec = mapper.convertValue(data, HuggingfaceServeFunctionSpec.class);
+    //     this.adapters = spec.getAdapters();
+    // }
 
     public static HuggingfaceServeFunctionSpec with(Map<String, Serializable> data) {
         HuggingfaceServeFunctionSpec spec = new HuggingfaceServeFunctionSpec();