Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-right-role-to-select #720

Merged
merged 2 commits into from
May 7, 2024
Merged

add-right-role-to-select #720

merged 2 commits into from
May 7, 2024

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented May 2, 2024

Component:

Description:

Design:

Breaking Changes:

  • [] Breaking Changes

Closes: #ISSUE_NUMBER

@bert-e
Copy link
Contributor

bert-e commented May 2, 2024

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 2, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote MonPote force-pushed the improvement/add-right-role-to-select branch from 5881391 to d831974 Compare May 6, 2024 15:47
@bert-e
Copy link
Contributor

bert-e commented May 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote MonPote changed the title test add-right-role-to-select May 6, 2024
@MonPote MonPote force-pushed the improvement/add-right-role-to-select branch from d831974 to c15ca48 Compare May 6, 2024 15:48
@MonPote MonPote marked this pull request as ready for review May 6, 2024 15:49
MonPote added 2 commits May 7, 2024 10:46
@MonPote
move the aria label of select from input to the container
df92ff4 
This commit fix a testing issue, it does not change anything about
the select component behavior.

react-select does not render our 'input' when the it's not 'searchable'.
-> the aria label definition is put on the container

In order to help for the testing when we have several selects, we want
to have an aria-label, it's define by the placeholder because it's
what the user see (vs the id)
@MonPote
add select test examples
68f2a83
@MonPote MonPote force-pushed the improvement/add-right-role-to-select branch from c15ca48 to 68f2a83 Compare May 7, 2024 08:57
@bert-e
Copy link
Contributor

bert-e commented May 7, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote
Copy link
Contributor Author

MonPote commented May 7, 2024

/approve

@bert-e
Copy link
Contributor

bert-e commented May 7, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye monpote.

The following options are set: approve

@bert-e bert-e merged commit 68f2a83 into development/1.0 May 7, 2024
4 checks passed
@MonPote MonPote deleted the improvement/add-right-role-to-select branch May 7, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MonPote @bert-e @ChengYanJin