From 5bb68393ddd02602223224eb84717dc1c5211485 Mon Sep 17 00:00:00 2001
From: Jean-Marc Millet <jean-marc.millet@scality.com>
Date: Thu, 6 Jun 2024 11:39:43 +0200
Subject: [PATCH 1/2] call useHistory in EmptyState and remove history from
 props

---
 .../emptystate/Emptystate.component.tsx           | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/lib/components/emptystate/Emptystate.component.tsx b/src/lib/components/emptystate/Emptystate.component.tsx
index aad25aaff8..8cc20be3a9 100644
--- a/src/lib/components/emptystate/Emptystate.component.tsx
+++ b/src/lib/components/emptystate/Emptystate.component.tsx
@@ -5,6 +5,7 @@ import { Button } from '../buttonv2/Buttonv2.component';
 import { Icon, IconName } from '../icon/Icon.component';
 import { LargeText } from '../text/Text.component';
 import { CoreUITheme } from '../../style/theme';
+import { useHistory } from 'react-router';
 type Props = {
   listedResource: {
     singular: string;
@@ -12,7 +13,6 @@ type Props = {
   };
   icon: IconName;
   link?: string;
-  history?: Record<string, any>;
   backgroundColor?: keyof CoreUITheme;
   /**
    * The resource to create before browsing the listed resource
@@ -46,14 +46,9 @@ export const ActionWrapper = styled.div`
 `;
 
 function EmptyState(props: Props) {
-  const {
-    icon,
-    listedResource,
-    link,
-    history,
-    resourceToCreate,
-    backgroundColor,
-  } = props;
+  const { icon, listedResource, link, resourceToCreate, backgroundColor } =
+    props;
+  const history = useHistory();
   return (
     <EmptystateContainer
       className="sc-emptystate"
@@ -72,7 +67,7 @@ function EmptyState(props: Props) {
             : `Before browsing your ${listedResource.plural}, create your first ${resourceToCreate}.`}
         </LargeText>
       </EmptyStateRow>
-      {history && (
+      {link && (
         <ActionWrapper>
           <Button
             label={`Create ${resourceToCreate || listedResource.singular}`}

From 392377e91812e2e207f260006d50b936fab2b1e3 Mon Sep 17 00:00:00 2001
From: Jean-Marc Millet <jean-marc.millet@scality.com>
Date: Thu, 6 Jun 2024 11:55:03 +0200
Subject: [PATCH 2/2] update emptyState stories

---
 .../emptystate/Emptystate.component.tsx       |  4 ++--
 stories/emptystate.stories.tsx                | 23 ++++++++++++-------
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/src/lib/components/emptystate/Emptystate.component.tsx b/src/lib/components/emptystate/Emptystate.component.tsx
index 8cc20be3a9..41c95b8e7a 100644
--- a/src/lib/components/emptystate/Emptystate.component.tsx
+++ b/src/lib/components/emptystate/Emptystate.component.tsx
@@ -1,12 +1,12 @@
 import styled, { css } from 'styled-components';
-
 import { spacing } from '../../spacing';
 import { Button } from '../buttonv2/Buttonv2.component';
 import { Icon, IconName } from '../icon/Icon.component';
 import { LargeText } from '../text/Text.component';
 import { CoreUITheme } from '../../style/theme';
 import { useHistory } from 'react-router';
-type Props = {
+
+export type Props = {
   listedResource: {
     singular: string;
     plural: string;
diff --git a/stories/emptystate.stories.tsx b/stories/emptystate.stories.tsx
index 2b74ebdcb7..92d6c1eeb7 100644
--- a/stories/emptystate.stories.tsx
+++ b/stories/emptystate.stories.tsx
@@ -1,21 +1,28 @@
-import { EmptyState } from '../src/lib/components/emptystate/Emptystate.component';
+import { Meta, StoryObj } from '@storybook/react';
+import {
+  EmptyState,
+  Props,
+} from '../src/lib/components/emptystate/Emptystate.component';
+type Story = StoryObj<Props>;
 
-export default {
+const meta: Meta<Props> = {
   title: 'Components/Data Display/EmptyState',
   component: EmptyState,
   args: {
     icon: 'Node-backend',
-    label: 'Node',
+    listedResource: {
+      singular: 'resource',
+      plural: 'resources',
+    },
   },
 };
 
-export const Default = {};
+export default meta;
+
+export const Default: Story = {};
 
-export const WithLink = {
+export const WithLink: Story = {
   args: {
     link: '',
-    history: {
-      push: () => {},
-    },
   },
 };