Update GitHub Actions guide to include setup-sbt action #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzuehlke
reviewed
Jan 8, 2025
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 |
There was a problem hiding this comment.
I think it is good to specify sbt caching: https://github.com/actions/setup-java#caching-packages-dependencies
It's use like this here, e.g.: https://github.com/sbt/sbt-native-packager/blob/main/.github/workflows/validate-pr.yml#L19-L24
There was a problem hiding this comment.
There is already a section on caching on that page that talks about adding that exact option.
The whole page could do with a full rewrite to bring it up date but that can be done on the new docs site. For now I wanted to do a quick update so that the examples work.
There was a problem hiding this comment.
Sorry, my bad I was only looking at the diff 🙈
|
@stringbean Could you sign the Scala CLA please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step is needed now that sbt has been removed from the default Ubuntu & macOS runners.
Also bumps the sbt version in the documentation to 1.10.7.