Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on high level validation, ruleId=pd10112: if there are compartments defined, top-level glyphs must have a compartmentRef. #51

Open
ibalaur opened this issue May 26, 2019 · 2 comments
Labels

Comments

@ibalaur
Copy link
Collaborator

ibalaur commented May 26, 2019

The high level validation (using libSBGN 3.0) failed due to not having all top-level glyphs referring to a compartment. Please see the attached files: input SBGN-ML and output validation message. However, the input SBGN-ML file validates with SBGN-ED.
Users often draw diagrams without taking subcellular locations into account at that stage, and some molecules could be from extracellular space, some on the membrane and some inside cell. Maybe in the validation it should not be that strict and required information on compartments?

Could you please advise on this difference/ further use?
Thank you very much.

F014-carnitine-SBGNv02.sbgn.zip
MR_F014-carnitine_SBGN_Validation.docx

@ibalaur ibalaur changed the title Quesiton on high level validation: if there are compartments defined, top-level glyphs must have a compartmentRef. Question on high level validation, ruleId=pd10112: if there are compartments defined, top-level glyphs must have a compartmentRef. May 26, 2019
@amazein
Copy link

amazein commented May 26, 2019

I second that. It would not be unusual to develop a diagram without thinking about the compartments yet. We can not force or assume some default compartment in my opinion.

@tczauderna
Copy link
Collaborator

Just as a quick comment.
SBGN-ED does not validate the SBGN-ML.
SBGN-ED just validates SBGN itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants