Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove old workspace #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't remove old workspace #24

wants to merge 1 commit into from

Conversation

dipunm
Copy link

@dipunm dipunm commented Sep 19, 2022

It seems gnome does this for us now so this function causes the whole desktop to crash. :(

see: #22

It seems gnome does this for us now so this function causes the whole desktop to crash. :(
@Jangberry
Copy link

Jangberry commented Sep 21, 2022

It seems like it crashes only when it tries deleting the workspace while there still is a window on it. Like I patched it correcting it by if (fullScreenWorkspace.list_windows().length == 0) {global.workspaceManager.remove_workspace(fullScreenWorkspace, global.get_current_time());}
Don't know wich one is the best just dropping my findings

Nevermind it provokes an other bug, more rare but more vicious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants