Using path.normalize and path.sep to overcome windows issues #38
Conversation
lib/broccoli_sass_compiler.js
Outdated
| @@ -485,7 +485,7 @@ BroccoliSassCompiler.prototype.handleCacheHit = function(details, inputAndOutput | |||
| BroccoliSassCompiler.prototype.scopedFileName = function(file) { | |||
| file = this.relativize(file); | |||
| if (this.treeName) { | |||
| return this.treeName + "/" + file; | |||
| return this.treeName + path.sep + file; | |||
There was a problem hiding this comment.
can you use path.join instead?
return path.join(this.treeName, file);
There was a problem hiding this comment.
Is there anything we can do to make this happen? This is a bit of a show stopper on Windows!
There was a problem hiding this comment.
Sorry for abandoning this PR, don't have an env suitable for testing anymore
You could probably apply a change, proposed above and test, I don't think it is the only place where paths are concatenated as strings, but it will be enough to make this PR accepted, hopefully.
|
I have applied a proposed change, but i don't have a real way to test atm. would be nice if @MrChriZ could test this and verify everything is working |
|
Thanks @MaksimBurnin. I'm actually using this library by proxy in that I discovered the issue whilst trying to use https://github.com/sass-eyeglass/ember-cli-eyeglass. |
|
Running a little late with this one - got steamrolled by a few other things. |
|
OK I cheated... I copied your updated file into my node_modules/broccoli-eyeglass folder... and low and behold it works (ish)! The only issue I have is my cssDir option is completely ignored. I have no idea whether this is related to your update, broccoli-eyeglass, or embler-cli-eyeglass |
|
@MrChriZ Thanks for you effort. |
|
@chriseppstein @stefanpenner Could you guys look into merging or rejecting this one? |
@MaksimBurnin sorry, I don't have any powerz on this repo. We'll have to wait for mr @chriseppstein |
|
I have powerz now, but we should likely only merge this an add actual windows supports once the tests pass in appveyor. |
Fixes #37