Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSD2 uses scipy.stats.median_absolute_deviation - deprecated in scipy 1.9.0 #42

Open
cgroeneveld opened this issue Mar 7, 2023 · 1 comment
Open

SSD2 uses scipy.stats.median_absolute_deviation - deprecated in scipy 1.9.0 #42

cgroeneveld opened this issue Mar 7, 2023 · 1 comment

Comments

@cgroeneveld
Copy link

cgroeneveld commented Mar 7, 2023 •
edited
Loading

SSD2 invokes ClassImageDeconvMachineMultiSlice, an in r50 this uses scipy.stats.median_absolute_deviation:

DDFacet/DDFacet/Imager/MultiSliceDeconv/ClassImageDeconvMachineMultiSlice.py

Line 50 in 053725b

MAD=scipy.stats.median_absolute_deviation

This is deprecated and after scipy-1.9.0 will directly lead to an error. This function has since been replaced by scipy.stats.median_abs_deviation.
@bennahugo
Copy link
Collaborator

Thanks for noting the deprecation. When we move to the newer versions of upstream dependencies we will try and incorporate. Leaving this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bennahugo @cgroeneveld