You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Python Exercise 1: Printing out vowels and consonants
A python script vowel_counter.py is supposed to print out the number of vowels and consonants in a string.
Several users have reported problems, and one user has put in a pull request to improve the script.
User reports:
Only vowels are getting printed out! This script is not working
This script is printing the number of consonants.
Why is `vowel_counter.py` even printing out the number of consonants?
Does the pull request address the issue? Yes. If vowel_counter.py is supposed to print out the number of vowels and consonants in a string.
Are the comments up to date, necessary, helpful? Would you remove some of these comments? Add suggestions for which comments to remove and/or change. I think the comments provided are up to date, necessary, and helpful.
What would improve the pull request? Could you use list comprehension? Would you except the solution as it is now? I would accept the answer as is. I may call it vowel_consonant_counter.py though. Oh, wait. The consonant counter is incorrect.
Python Exercise 1: Printing out vowels and consonants
A python script
vowel_counter.py
is supposed to print out the number of vowels and consonants in a string.Several users have reported problems, and one user has put in a pull request to improve the script.
User reports:
Take a look at the python script vowel_counter.py
Take a look at the pull request.
The text was updated successfully, but these errors were encountered: